Fixes for earlier macOS#7932
Merged
SparkiDev merged 2 commits intowolfSSL:masterfrom Sep 10, 2024
Merged
Conversation
|
Can one of the admins verify this patch? |
12 tasks
Member
|
Hi @barracuda156, thanks for your PR's. In order to accept a third party contribution we need a signed agreement. Please email support at wolfssl dot com to get that process started. |
Member
|
Contributor agreement has been approved. We're good to move forward on this. |
SparkiDev
approved these changes
Sep 10, 2024
Contributor
Author
|
@SparkiDev Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This addresses two issues:
Current code simply assumes
libdispatchis available on macOS. This is not always true though: it does not exist prior to 10.6, and is not really tested onppcon 10.6 (there are also potential related problem here: for example, blocks are not supported in gcc, as of now, while clang is broken onppc).Instead, use
libdispatchwhere it exists for sure and is known to work, and otherwise use genetic POSIX. The code is unchanged, this simply changes the condition so that the right implementation is picked. There is no effect for non-Apple platforms.NOTE_TRIGGERmay not be available. If it is not present, butEV_TRIGGERis, use that one.