Update to use C99 instead of C11 because of lack of SGX support#7959
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Sep 10, 2024
Merged
Update to use C99 instead of C11 because of lack of SGX support#7959douzzer merged 1 commit intowolfSSL:masterfrom
douzzer merged 1 commit intowolfSSL:masterfrom
Conversation
Contributor
Author
|
retest this please |
douzzer
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After adding C11 memory fence support, the SGX nightly test failed with a missing stdatomic.h file. Our IDE/LINUX-SGX makefile erroneously forced C11 standard compliance, but SGX is only compatible with C99 and C++11. This change corrects the C standard to be C99 to match the libc that is embedded within the SGX include libraries.
Fixes job nightly-SGX_Linux-v2.
Note: I'm apply the same correction to wolfssl-examples SGX_LINUX.
Testing
Tested using boz-sgx, which is Ubuntu 18 with SGX SDK and matched build commands with script.
Checklist