Skip to content

Add cmake support for WOLFSSL_CUSTOM_CURVES#7962

Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
embhorn:zd18558
Sep 18, 2024
Merged

Add cmake support for WOLFSSL_CUSTOM_CURVES#7962
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
embhorn:zd18558

Conversation

@embhorn
Copy link
Copy Markdown
Member

@embhorn embhorn commented Sep 11, 2024

Description

Add support for the WOLFSSL_CUSTOM_CURVES define in the cmake build.

Fixes zd18558

Testing

mkdir build && cd build
cmake -DWOLFSSL_ECCCUSTCURVES=all ..
cmake --build .
sudo cmake --build . --target install

Build ECC examples in https://github.com/wolfSSL/wolfssl-examples/tree/master/ecc
Then run ecc-verify example and see that Not compiled in... error is not displayed.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@embhorn embhorn self-assigned this Sep 11, 2024
@embhorn
Copy link
Copy Markdown
Member Author

embhorn commented Sep 11, 2024

retest this please

Build [PRB-generic-config-parser #5731](https://cloud.wolfssl-test.com/jenkins/job/PRB-generic-config-parser/5731/) completed: FAILURE
[Pipeline] }
[PRB-generic-config-parser #5731](https://cloud.wolfssl-test.com/jenkins/job/PRB-generic-config-parser/5731/) completed with status FAILURE (propagate: false to ignore)
org.jenkinsci.plugins.workflow.actions.ErrorAction$ErrorId: 254322d1-bcec-464e-a117-64e66ad16278
Setting overall build result to FAILURE
[Pipeline] // catchError
[Pipeline] }

@embhorn
Copy link
Copy Markdown
Member Author

embhorn commented Sep 16, 2024

Customer confirms working

@embhorn embhorn requested a review from lealem47 September 16, 2024 15:40
@embhorn embhorn assigned lealem47 and unassigned embhorn Sep 16, 2024
@lealem47 lealem47 assigned wolfSSL-Bot and unassigned lealem47 Sep 17, 2024
@JacobBarthelmeh JacobBarthelmeh merged commit ec8a1ba into wolfSSL:master Sep 18, 2024
@embhorn embhorn deleted the zd18558 branch April 24, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants