20240916-wc_DhAgree_ct-sp-math#7978
Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom Sep 16, 2024
Merged
Conversation
…ime key size fixup, to work around sp-math constant-time key clamping. also fix a -Wunused in src/ssl_load.c:DataToDerBuffer() teased out by configuration permutations.
douzzer
force-pushed
the
20240916-wc_DhAgree_ct-sp-math
branch
from
db6c154 to
04c781a
Compare
SparkiDev
approved these changes
Sep 16, 2024
Contributor
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfcrypt/src/dh.c: inwc_DhAgree_ct(), implement failsafe constant-time key size fixup, to work around sp-math constant-time key clamping.tested with
wolfssl-multi-test.sh ... super-quick-check, plus a loop of over 3000 iters ofunit.test -test_wolfSSL_DHto characterize the undersize-key rate (~.64%).