20240930-clang-tidy#8031
Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom Oct 1, 2024
Merged
Conversation
examples/pem/pem.c: fix stdio stream leaks. src/ssl.c and src/ssl_load.c: suppress concurrency-mt-unsafe around getenv(). getenv() is threadsafe as long as no threads putenv() or setenv(). wolfssl/openssl/asn1.h: add parentheses to fix bugprone-macro-parentheses in ASN1_EX_TEMPLATE_TYPE(), and suppress misfiring bugprone-macro-parentheses around IMPLEMENT_ASN1_FUNCTIONS().
SparkiDev
approved these changes
Oct 1, 2024
Contributor
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes, coddling, and suppressions for new true-positive
clang-tidycomplaints:examples/pem/pem.c: fix stdio stream leaks.src/ssl.candsrc/ssl_load.c: suppressconcurrency-mt-unsafearoundgetenv().getenv()is threadsafe as long as no threadsputenv()orsetenv().wolfssl/openssl/asn1.h: add parentheses to fixbugprone-macro-parenthesesinASN1_EX_TEMPLATE_TYPE(), and suppress misfiringbugprone-macro-parenthesesaroundIMPLEMENT_ASN1_FUNCTIONS().detected and tested with
wolfssl-multi-test.sh ... super-quick-checkwithsys-devel/clang-20.0.0_pre20240924note new suppression added to
wolfssl-multi-test.shfor this:see also llvm/llvm-project#110551