20241001-fixes#8033
Merged
SparkiDev merged 1 commit intowolfSSL:masterfrom Oct 1, 2024
Merged
Conversation
configure.ac and src/include.am: add ENABLED_ARM_THUMB, BUILD_ARM_THUMB, BUILD_ARM_NONTHUMB, ENABLED_ARM_64, BUILD_ARM_64, ENABLED_ARM_32. and BUILD_ARM_32, and use them to gate building of ARM asm files, to fix "ISO C forbids an empty translation unit" warnings (the warning only affects inline asm files, but the gating is deployed more widely).
SparkiDev
requested changes
Oct 1, 2024
SparkiDev
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/pem/pem.c: fixdouble-freeintroduced in 65853a4;configure.acandsrc/include.am: addENABLED_ARM_THUMB,BUILD_ARM_THUMB,BUILD_ARM_NONTHUMB,ENABLED_ARM_64,BUILD_ARM_64,ENABLED_ARM_32. andBUILD_ARM_32, and use them to gate building of ARM asm files, to fix "ISO C forbids an empty translation unit" warnings (the warning only affects inline asm files, but the gating is deployed more widely).tested with
wolfssl-multi-test.sh ... quantum-safe-wolfssl-all-clang-tidy quantum-safe-wolfssl-all-intelasm-sp-asm-sanitizer quantum-safe-wolfssl-all-cross-aarch64-armasm-unittest-sanitizer cross-armv6zk-all cross-armv7a-all cross-armv7m-armasm-thumb-sp-asm-all-crypto-only cross-armv7m-armasm-thumb-fips-140-3-dev-sp-asm-all-crypto-only cross-armv6zk-thumb-all-asm check-source-text check-source-text-fips-dev check-configure