Regression test fixes#8064
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Oct 15, 2024
Merged
Conversation
SparkiDev
force-pushed
the
regression_fixes_14
branch
from
c759d09 to
c5e8bc6
Compare
Fix unit tests to not compile when NO_RSA is defined and RSA used. test_wc_PKCS7_EncodeSignedData: only RSA supported with streaming. test_wolfSSL_RSA when SP math and SP: CRT parameters required. test_wolfSSL_OCSP_REQ_CTX to compile with NO_ASN_TIME. test_wolfSSL_IMPLEMENT_ASN1_FUNCTIONS: make sure all objects freed even on memory allocation failure. test_wolfSSL_error_cb: don't use bio if is NULL. test_wolfSSL_BN_enc_dec: don't free a twice on memory allocation error. test_wc_dilithium_der: remove debug printing test_othername_and_SID_ext: make sid_oid NULL after free to ensure no double free on later memory allocation failure. test_wolfSSL_RSA: don't leak when BN_dup fails. test_wolfSSL_i2d_ASN1_TYPE: free ASN1 string whn no ASN1 type to put it into. test_tls13_rpk_handshake: don't leak on failure test_dtls_client_hello_timeout_downgrade: only move memory when test is wolfSSL_certs_clear, wolfSSL_set_SSL_CTX, SetSSL_CTX: Check return from AllocCopyDer. d2i_generic: make sure impBuf is only freed once. wolfSSL_BIO_write: don't dereference front unless it is not NULL. wolfssl_dns_entry_othername_to_gn: don't free obj twice wolfSSL_X509_REQ_add1_attr_by_NID: don't access reqAttributes if NULL. succeeding.
SparkiDev
force-pushed
the
regression_fixes_14
branch
from
c5e8bc6 to
5f1ddad
Compare
douzzer
approved these changes
Oct 15, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix unit tests to not compile when NO_RSA is defined and RSA used.
test_wc_PKCS7_EncodeSignedData: only RSA supported with streaming.
test_wolfSSL_RSA when SP math and SP: CRT parameters required.
test_wolfSSL_OCSP_REQ_CTX to compile with NO_ASN_TIME.
test_wolfSSL_IMPLEMENT_ASN1_FUNCTIONS: make sure all objects freed even on memory allocation failure.
test_wolfSSL_error_cb: don't use bio if is NULL.
test_wolfSSL_BN_enc_dec: don't free a twice on memory allocation error.
test_wc_dilithium_der: remove debug printing
test_othername_and_SID_ext: make sid_oid NULL after free to ensure no double free on later memory allocation failure.
test_wolfSSL_RSA: don't leak when BN_dup fails.
test_wolfSSL_i2d_ASN1_TYPE: free ASN1 string whn no ASN1 type to put it into.
test_tls13_rpk_handshake: don't leak on failure
test_dtls_client_hello_timeout_downgrade: only move memory when test is succeeding.
wolfSSL_certs_clear, wolfSSL_set_SSL_CTX, SetSSL_CTX: Check return from AllocCopyDer.
d2i_generic: make sure impBuf is only freed once.
wolfSSL_BIO_write: don't dereference front unless it is not NULL.
wolfssl_dns_entry_othername_to_gn: don't free obj twice
wolfSSL_X509_REQ_add1_attr_by_NID: don't access reqAttributes if NULL.
Testing
Memory allocation failure testing.
Checklist