Merged
Conversation
…rect names have WOLFSSL_ prefixes).
…ize guard against zero-length len added in 03a6eed, to fix test_wc_ecc_get_curve_id_from_oid() failing in cross-mingw-all-crypto.
…d-id=none, to support users relying on build-id in the linked object.
…crypto that are already included indirectly in enable-all.
…N_STATE_DO section for the benefit of WOLFSSL_DEBUG_TRACE_ERROR_CODES.
…not OPENSSL_EXTRA, as it fails with --enable-all-crypto --enable-opensslextra, and is commented to require --enable-opensslall.
douzzer
requested review from
JacobBarthelmeh,
SparkiDev,
embhorn and
lealem47
JacobBarthelmeh
approved these changes
Oct 23, 2024
Contributor
JacobBarthelmeh
left a comment
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Please grep for other occurrences of HAVE_ macros and follow up with changes as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix references to misnamed
HAVE_SHA224,HAVE_SHA384,HAVE_SHA512(correct names haveWOLFSSL_prefixes).wolfcrypt/src/ecc.c: inwc_ecc_get_curve_id_from_oid(), deconditionalize guard against zero-lengthlenadded in 03a6eed, to fixtest_wc_ecc_get_curve_id_from_oid()failing incross-mingw-all-crypto.configure.ac: for reproducible-build, use--build-id=sha1, not--build-id=none, to support users relying on build-id in the linked object.configure.ac: add several missing low level crypto algorithms toall-cryptothat are already included indirectly inenable-all.wolfcrypt/src/asn.c: tweakrethandling inMakeSignature()CERTSIGN_STATE_DOsection for the benefit ofWOLFSSL_DEBUG_TRACE_ERROR_CODES.tests/api.c: gatetest_GENERAL_NAME_set0_othername()onOPENSSL_ALL, notOPENSSL_EXTRA, as it fails with--enable-all-crypto --enable-opensslextra, and is commented to require--enable-opensslall.tested with
wolfssl-multi-test.sh ... super-quick-check