Fix missing error codes when NO_SOCK and USER_IO are in use#8157
Closed
redbaron wants to merge 1 commit intowolfSSL:masterfrom
Closed
Fix missing error codes when NO_SOCK and USER_IO are in use#8157redbaron wants to merge 1 commit intowolfSSL:masterfrom
redbaron wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Functions in `wolfio.c` unconditionally reference SOCKET_* error codes, even if `errno.h` is conditionally includes in wolfio.h. When compiled with at least WOLFSSL_NO_SOCK + WOLFSSO_USER_IO `wolfio.h` decides not to include `errno.h` and therefore SOCKET_* symbols are missing. Instead of changing "decision tree" in `wolfio.h` and risking breaking it on platforms I couldn't test, use "last resort" include of 'errno.h' in the wolfio.c if configure process detected its presence.
|
Can one of the admins verify this patch? |
Member
|
Hi @redbaron, Thank you for this PR. I do not see you are an approved contributor. For such a small change we will likely treat as a bug report, attempt to reproduce and fix ourselves. Can you tell us more about your project? Thanks, David Garske, wolfSSL |
Member
|
@redbaron is approved as a wolfSSL contributor |
Merged
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Functions in
wolfio.cunconditionally reference SOCKET_* error codes, even iferrno.his conditionally included in wolfio.h.When compiled with at least WOLFSSL_NO_SOCK + WOLFSSO_USER_IO
wolfio.hdecides not to includeerrno.hand therefore SOCKET_* symbols are missing.Instead of changing "decision tree" in
wolfio.hand risking breaking it on platforms I couldn't test, use "last resort" include of 'errno.h' in the wolfio.c if configure process detected its presence.Testing
Built with WOLFSSL_USER_IO and WOLFSSL_NO_SOCK
Checklist