/dev/crypto auth error fix/adjustment for benchmark#8210
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Nov 25, 2024
Merged
/dev/crypto auth error fix/adjustment for benchmark#8210JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
64129b7 to
eebd121
Compare
Member
|
Retest this please - Python test |
JacobBarthelmeh
approved these changes
Nov 22, 2024
Contributor
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Looks like sysconf is in QNX too (another system which has /dev/crypto) which is good, so seems portable enough for a call wrapped with the debug macro guard. Assign to wolfssl-bot when ready for a final review and potential merge into master branch.
Contributor
Author
JacobBarthelmeh
requested changes
Nov 25, 2024
Contributor
JacobBarthelmeh
left a comment
There was a problem hiding this comment.
Works as expected. Please resolve this warning though:
CC examples/server/examples_server_server-server.o
wolfcrypt/benchmark/benchmark.c: In function ‘bench_gmac’:
wolfcrypt/benchmark/benchmark.c:4846:71: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long int’ [-Wformat=]
printf("authIn Buffer Size[%d] greater than System Page Size[%d]\n",
~^
%ld
bench_size, sysconf(_SC_PAGESIZE));
~~~~~~~~~~~~~~~~~~~~~
CC examples/pem/pem.o
7dc7887 to
02e6ec0
Compare
Contributor
Author
|
Fixed to resolve warning with benchmark, and squashed. |
JacobBarthelmeh
approved these changes
Nov 25, 2024
Contributor
Author
|
Retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When configuring wolfSSL to use
/dev/cryptoand running our benchmark tool, GMAC benchmarks will throw the-265error code after calling this line.This is because is due to this line in
/dev/cryptodriver.This PR adds better debugging and will set size when running GMAC to that of the system's page size. It also allows for an override for this size by setting the macro
WOLFSSL_AUTHSZ_BENCH