TLS EMS: Set haveEMS when we negotiate TLS 1.3#8487
Merged
dgarske merged 5 commits intowolfSSL:masterfrom Apr 9, 2025
Merged
Conversation
Member
julek-wolfssl
commented
Feb 21, 2025
julek-wolfssl
commented
- Move extended master secret testing to test_tls_ext.c
julek-wolfssl
force-pushed
the
zd/19391
branch
2 times, most recently
from
0ce4d25 to
2442bac
Compare
Member
|
Retest this please: "hudson.remoting.RequestAbortedException exception:" |
dgarske
previously approved these changes
Mar 3, 2025
Member
Author
|
Rebased to master to fix merge conflicts. |
SparkiDev
previously approved these changes
Mar 4, 2025
Member
|
Retest this please. History lost. |
dgarske
approved these changes
Mar 6, 2025
dgarske
requested changes
Mar 6, 2025
Member
Author
|
Jenkins failure not relevant. |
SparkiDev
previously approved these changes
Apr 3, 2025
Member
|
Retest this please. History lost. |
dgarske
requested changes
Apr 7, 2025
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
./configure --with-liboqs --enable-experimental && make && ./tests/unit.test
Stage 'PRB-liboqs.txt_0'
FAILURES:
1018: test_tls_ems_downgrade
dgarske
approved these changes
Apr 8, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (2)
- CMakeLists.txt: Language not supported
- tests/api/include.am: Language not supported
Comments suppressed due to low confidence (1)
tests/api/test_tls_ext.h:1
- [nitpick] The header file comment refers to 'test_tls_ems.h', which does not match the file name 'test_tls_ext.h'. Consider updating the comment for consistency.
/* test_tls_ems.h
dgarske
requested changes
Apr 8, 2025
Member
Author
|
Retest this please |
dgarske
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.