Merged
Conversation
Fixes two clang-tidy warnings in error cases. Signed-off-by: Tobias Frauenschläger <tobias.frauenschlaeger@oth-regensburg.de>
|
Can one of the admins verify this patch? |
Contributor
|
Okay to test. Contributor agreement on file. Thank you @Frauschi |
dgarske
approved these changes
Feb 24, 2025
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
This passes the clang-tidy
Contributor
|
Retest this please: |
douzzer
approved these changes
Feb 24, 2025
Contributor
douzzer
left a comment
douzzer
left a comment
There was a problem hiding this comment.
passes pq-all-clang-tidy pq-hybrid-all-rpk-clang-tidy quantum-safe-wolfssl-all-clang-tidy quantum-safe-wolfssl-all-smallstack-clang-tidy quantum-safe-wolfssl-all-intelasm-sp-asm-sanitizer quantum-safe-wolfssl-all-intelasm-sp-asm-valgrind
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two Clang-tidy warnings caused by #7821 (sent via mail by @dgarske).