Skip to content

Various fixes and improvements#8494

Merged
SparkiDev merged 6 commits intowolfSSL:masterfrom
Laboratory-for-Safe-and-Secure-Systems:various
Feb 26, 2025
Merged

Various fixes and improvements#8494
SparkiDev merged 6 commits intowolfSSL:masterfrom
Laboratory-for-Safe-and-Secure-Systems:various

Conversation

@Frauschi
Copy link
Copy Markdown
Contributor

@Frauschi Frauschi commented Feb 24, 2025

Hi all,

this PR adds various smaller fixes and improvements I encountered:

  • Some fixes to properly use the final ML-DSA version of Dilitihium in the TLS handshake (this add interoperability with OQS)
  • Extend the crypto callback API for PQC algorithms to match the final version
  • Fix a Dilithium memory leak
  • Fix compilation of Dilithium code in case the caching is enabled
  • Minor fix for using PSKs without Session tickets
  • Add CMake and Zephyr support for XMSS and LMS
  • Minor fix for LMS keys when a public key is imported to a reloaded private key

@wolfSSL-Bot
Copy link
Copy Markdown

wolfSSL-Bot commented Feb 24, 2025

Can one of the admins verify this patch?

@dgarske
Copy link
Copy Markdown
Member

dgarske commented Feb 24, 2025

Okay to test. Contributor agreement on file. Thank you @Frauschi

@dgarske dgarske requested review from anhu, dgarske and douzzer February 24, 2025 15:00
@Frauschi
Copy link
Copy Markdown
Contributor Author

Frauschi commented Feb 25, 2025

Rebased to current master to fix the mosquitto cert problem. I cannot reproduce the other failing tests on my side, any hints there?

@dgarske
Copy link
Copy Markdown
Member

dgarske commented Feb 25, 2025

Retest this please: "Found unhandled hudson.remoting.RequestAbortedException exception:"

@anhu
Copy link
Copy Markdown
Member

anhu commented Feb 25, 2025

fix the mosquitto cert problem.

Can you give more details on this?

@Frauschi
Copy link
Copy Markdown
Contributor Author

Frauschi commented Feb 25, 2025

fix the mosquitto cert problem.

Can you give more details on this?

A rebase for PR #8496 is meant, as the expired cert caused a failing test in this PR.

anhu
anhu previously approved these changes Feb 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@anhu anhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes requested, but I'd love an answer to my question about switching to ctx API.

Comment thread src/tls13.c
@anhu
Copy link
Copy Markdown
Member

anhu commented Feb 25, 2025

A rebase for PR #8496 is meant, as the expired cert caused a failing test in this PR.

Thank you!!

dgarske
dgarske requested changes Feb 25, 2025
View reviewed changes
Comment thread wolfssl/wolfcrypt/cryptocb.h Outdated
@dgarske dgarske assigned Frauschi and unassigned anhu and douzzer Feb 25, 2025
@Frauschi
Fixes for Dilithium in TLS handshake
be6888c 
Some fixes to better handle Dilithium keys and signatures in the TLS
handshake.

Signed-off-by: Tobias Frauenschläger <tobias.frauenschlaeger@oth-regensburg.de>
@Frauschi
Update CryptoCb API for Dilithium final standard
9db5499 
Add context and preHash metadata.

Signed-off-by: Tobias Frauenschläger <tobias.frauenschlaeger@oth-regensburg.de>
@Frauschi
LMS fixes
af40171 
* Add support for CMake
* Add support for Zephyr
* Make sure the internal key state is properly handled in case a public
  key is imported into a reloaded private key.

Signed-off-by: Tobias Frauenschläger <tobias.frauenschlaeger@oth-regensburg.de>
@Frauschi
Minor Dilithium fix
3d4ec14 
Fix compilation in case caching is enabled.

Signed-off-by: Tobias Frauenschläger <tobias.frauenschlaeger@oth-regensburg.de>
@Frauschi
PSK fix
491e70b 
Fix compilation in case PSK is enabled, not Session tickets are
disabled.

Signed-off-by: Tobias Frauenschläger <tobias.frauenschlaeger@oth-regensburg.de>
@Frauschi
Fix memory leak in handshake
75d6307 
Make sure peer dilithium keys are properly freed.

Signed-off-by: Tobias Frauenschläger <tobias.frauenschlaeger@oth-regensburg.de>
@dgarske
Copy link
Copy Markdown
Member

dgarske commented Feb 26, 2025

Retest this please. Some of the tests were aborted?

@dgarske dgarske assigned SparkiDev and unassigned Frauschi Feb 26, 2025
anhu
anhu approved these changes Feb 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@anhu anhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good!!

@SparkiDev SparkiDev removed the request for review from douzzer February 26, 2025 23:39
@SparkiDev SparkiDev merged commit 99f25c6 into wolfSSL:master Feb 26, 2025
@Frauschi Frauschi deleted the various branch February 27, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anhu anhu anhu approved these changes

@dgarske dgarske dgarske approved these changes

@SparkiDev SparkiDev SparkiDev approved these changes

Assignees

@wolfSSL-Bot wolfSSL-Bot

@SparkiDev SparkiDev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Frauschi @wolfSSL-Bot @dgarske @anhu @SparkiDev @douzzer