CRL: fix memory allocation failure leaks#8499
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Feb 25, 2025
Merged
Conversation
SparkiDev
force-pushed
the
crl_list_fix
branch
from
5d45f77 to
e143875
Compare
On memory allocation failure, some functions were leaking memory. Also add reference counting to CRL object so that a deep copy of a list of CRLs doesn't leak memory. The test was explicitly freeing each CRL in the list.
SparkiDev
force-pushed
the
crl_list_fix
branch
from
e143875 to
6f268c4
Compare
Contributor
Author
|
retest this please hudson |
dgarske
approved these changes
Feb 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On memory allocation failure, some functions were leaking memory.
Also add reference counting to CRL object so that a deep copy of a list of CRLs doesn't leak memory.
The test was explicitly freeing each CRL in the list.
Testing
./configure '--disable-shared' '--enable-crl' '--enable-opensslall'
/test_X509_STORE_get0_objects was explicitly freeing the deep copied list.
Checklist