20250313-various-fixes#8563
Merged
kaleb-himes merged 2 commits intowolfSSL:masterfrom Mar 14, 2025
Merged
Conversation
* sense assert.h and define WOLFSSL_HAVE_ASSERT_H accordingly. * force off enable_aesgcm_stream if 32 bit armasm or riscv-asm (not yet implemented or buildable). * add AM_CONDITIONAL([BUILD_CHACHA_NOASM, ...]) when --enable-chacha=noasm. src/include.am: gate armasm/riscv_asm chacha files on !BUILD_CHACHA_NOASM. tests/api.c: add missing HAVE_CHACHA&&HAVE_POLY1305 gate around test_TLSX_CA_NAMES_bad_extension(). wolfcrypt/src/chacha.c: tweak WOLFSSL_ARMASM and WOLFSSL_RISCV_ASM codepaths to also depend on !NO_CHACHA_ASM. wolfssl/wolfcrypt/types.h: in setup for wc_static_assert(), #include <assert.h> if WOLFSSL_HAVE_ASSERT_H, >=C11, or >=C++11.
SparkiDev
previously approved these changes
Mar 14, 2025
…ERT_H && !WOLFSSL_NO_ASSERT_H. wolfssl/wolfcrypt/settings.h: #ifdef WOLFSSL_LINUXKM, #undef WOLFSSL_HAVE_ASSERT_H and #define WOLFSSL_NO_ASSERT_H.
Contributor
Author
|
retest this please ( |
kaleb-himes
requested changes
Mar 14, 2025
Contributor
Author
|
re |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
configure.ac:assert.hand defineWOLFSSL_HAVE_ASSERT_Haccordingly.enable_aesgcm_streamif 32 bit armasm or riscv-asm (not yet implemented or buildable).AM_CONDITIONAL([BUILD_CHACHA_NOASM, ...])when--enable-chacha=noasm.src/include.am: gate armasm/riscv_asm chacha files on!BUILD_CHACHA_NOASM.tests/api.c: add missingHAVE_CHACHA&&HAVE_POLY1305gate aroundtest_TLSX_CA_NAMES_bad_extension().wolfcrypt/src/chacha.c: tweakWOLFSSL_ARMASMandWOLFSSL_RISCV_ASMcodepaths to also depend on !NO_CHACHA_ASM.wolfssl/wolfcrypt/types.h: in setup forwc_static_assert(),#include <assert.h>ifWOLFSSL_HAVE_ASSERT_H, >=C11, or >=C++11.tested with