Ada: preparation for Alire index and fixes detected by GNATprove #8606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow enabling WOLFSSL_STATIC_PSK via an Alire configuration variable - `gnat.adc` applies unconditionally when using the library through Alire, so it has been renamed and used only in the default project file. - Clean-up of the Alire project file `wolfssl.gpr`.
Detected by ``` gnatprove -Pclient.gpr --level=4 -j12 ```
Checked with: ``` gnatprove -Pdefault.gpr --level=4 -j12 ```
|
Can one of the admins verify this patch? |
Contributor
|
Okay to test. Contributor agreement on file. Thank you @mgrojo |
Contributor
|
@mgrojo it looks like a lot of the failures reported are due to the new file restricted.adc and |
- Align README.md and GPR files with the fact that the server no longer compiles with the No_Secondary_Stack restriction. - Fix include.am to reference the new name for the adc file.
Contributor
Author
|
The checks should be working now. At least I solved it locally. I also restructured the project files, because the server example was no longer compiling with the No_Secondary_Stack restriction, at least since #7397. |
Contributor
Author
|
I've reviewed the 6 failing checks and haven't found any anything that seems to be related to the changes in the pull request, so I assume there's anything else to do on my part. |
Contributor
JacobBarthelmeh
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prepares WolfSSL for adding the Ada binding to the Alire index. See issue #8490.
It also fixes some issues identified by GNATprove that were broken in previous contributions (at least #8332).
Testing
How did you test?
Automated tests from https://github.com/mgrojo/coap_spark
For SPARK checks:
Checklist
Not required.