Detect unknown key format on ProcessBufferTryDecode()#8630
Merged
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom Apr 3, 2025
Merged
Detect unknown key format on ProcessBufferTryDecode()#8630JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom
Conversation
kojiws
force-pushed
the
kojiws/more_strict_key_format_check
branch
from
d1b9fe7 to
179c47c
Compare
kojiws
force-pushed
the
kojiws/more_strict_key_format_check
branch
from
179c47c to
71ebad1
Compare
kojiws
changed the title
JacobBarthelmeh
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, the ProcessBufferTryDecode(..., int* keyFormat, ...) returns zero (=success) even though the *keyFormat is unknown value.
This PR will update the function to return a error code when the *keyFormat is unknown.
Testing
./configure&&make testChecklist