Update to expose reasonable DER buffer sizes for Curve25519 #8651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
wolfssl/wolfcrypt/curve448.h:47
- [nitpick] Consider renaming CURVE448_BUFSIZE to CURVE448_DER_BUFSIZE for clarity on its specific use for DER key exports.
CURVE448_BUFSIZE = 128, /* for DER exported keys temp buffer */
wolfssl/wolfcrypt/curve25519.h:49
- [nitpick] Consider renaming CURVE25519_BUFSIZE to CURVE25519_DER_BUFSIZE to explicitly reflect its purpose in DER key export operations.
CURVE25519_BUFSIZE = 128, /* for exported DER keys temp buffer */
SparkiDev
requested changes
Apr 8, 2025
Contributor
Author
|
Retest this please Jenkins |
billphipps
changed the title
SparkiDev
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following the pattern in ecc.h for ECC_BUFSIZE to expose a reasonable buffer size when exporting a Curve25519 key to DER, an enum was added to allow static allocation of DER buffers: CURVE25519_MAX_KEY_TO_DER_SZ.
Testing
Updates were made to the curve25519 API tests to use this new constant, rather than the magic number of 128 or the overestimation of ONEK_BUF.
Checklist