Various fixes for Aarch64/ARM32/Thumb2 ASM#8672
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Apr 15, 2025
Merged
Various fixes for Aarch64/ARM32/Thumb2 ASM#8672JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
cpuid.c: hwcaps not used. thumb2-*: ldm -> LDM sp_arm32.c: No register assignment, fix sp_*_from_bin sp_armthumb.c: fix sp_*_from_bin sp_cotexm.c: fix line lengths, fix sp_*_from_bin
Contributor
Author
|
retest this please |
JacobBarthelmeh
approved these changes
Apr 15, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes several issues in the assembly routines and related helper routines for Aarch64/ARM32/Thumb2 targets. The changes include corrections to register/digit assignments in the sp_*_from_bin functions, stylistic updates to assembly instructions (changing “ldm” to “LDM”), and a minor unused-variable warning fix in cpuid.c.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| wolfcrypt/src/sp_armthumb.c | Adjusts register assignment indexing in sp_*_from_bin functions |
| wolfcrypt/src/port/arm/thumb2-poly1305-asm_c.c | Updates assembly instruction syntax to use uppercase “LDM” |
| wolfcrypt/src/port/arm/thumb2-mlkem-asm_c.c | Updates assembly instruction syntax to use uppercase “LDM” |
| wolfcrypt/src/port/arm/thumb2-chacha-asm_c.c | Updates assembly instruction syntax to use uppercase “LDM” |
| wolfcrypt/src/port/arm/thumb2-aes-asm_c.c | Updates assembly instruction syntax to use uppercase “LDM” |
| wolfcrypt/src/cpuid.c | Suppresses unused variable warning for hwcaps with (void)hwcaps |
Comments suppressed due to low confidence (1)
wolfcrypt/src/sp_armthumb.c:114
- The new indexing expression d[i-0] is equivalent to d[i], which reverses the assignment order compared to the original hard-coded index d[0]. For example, if i equals 2 then case 2 now assigns to d[0] instead of d[2]. Please verify that this reordering is intentional.
case 0: d[i-0] = a[0]; //fallthrough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cpuid.c: hwcaps not used.
thumb2-: ldm -> LDM
sp_arm32.c: No register assignment, fix sp_from_bin
sp_armthumb.c: fix spfrom_bin
sp_cotexm.c: fix line lengths, fix sp_from_bin
Testing
Regression tested ARM assembly builds.
Checklist