Fix types.h for MSVC6.0#8678
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Apr 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates wolfssl/wolfcrypt/types.h to support MSVC6.0 by replacing the "long long" data type with MSVC6.0’s native __int64 types.
- Added an explicit condition for MSVC6.0 using (_MSC_VER == 1200).
- Retained existing checks for other MSVC versions and compilers.
Comments suppressed due to low confidence (1)
wolfssl/wolfcrypt/types.h:255
- [nitpick] Consider enhancing the inline comment to clarify why MSVC6.0 is treated separately, ensuring the rationale is immediately clear to maintainers.
#if (defined(_MSC_VER) && (_MSC_VER == 1200)) || /* MSVC6 */ \
Member
Author
|
Retest this please |
dgarske
requested changes
Apr 16, 2025
dgarske
approved these changes
Apr 17, 2025
douzzer
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MSVC6 does not have the "long long" data type. However, MSVC6 does have built-in support for
__int64andunsigned __int64. Windows.h is not necessary for this.Fixes zd19742
Testing
Customer conifirmed
Checklist