quickfix: add missing include to asn.h #8806
Closed
bigbrett wants to merge 1 commit intowolfSSL:masterfrom
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing dependency in asn.h by including hash.h when building in no‐malloc mode to resolve compiler errors introduced by upstream changes.
- Adds
#include <wolfssl/wolfcrypt/hash.h>underWOLFSSL_NO_MALLOC - Ensures
WC_MAX_DIGEST_SIZEis defined for the fixed‐size signature buffer
Comments suppressed due to low confidence (1)
wolfssl/wolfcrypt/asn.h:94
- Consider adding or enabling a CI build configuration for WOLFSSL_NO_MALLOC to catch missing includes or compilation errors in no‐malloc mode automatically.
#ifdef WOLFSSL_NO_MALLOC
bigbrett
changed the title
Contributor
Author
|
Jenkins retest this please |
1 similar comment
Contributor
Author
|
Jenkins retest this please |
Contributor
Contributor
Author
|
@dgarske ah okay good to know thx. I was just trying to be proactive. I can go ahead and close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds missing include to fix compiler errors in wolfBoot introduced when updating to the latest wolfSSL master. The wolfSSL upstream change that caused the error was introduced in #8725 -
WC_MAX_DIGEST_SIZEis used to size a buffer in the no malloc case, but is defined inhash.hwhich was never included byasn.h.Odd that our CI no malloc tests weren't able to catch this... I suspect it has something to do with using configure vs the wolfBoot user settings and makefile?
Let me know if you think there is a better way to do it.