Fix blake2b_final coverity reports#9003
Merged
JacobBarthelmeh merged 2 commits intowolfSSL:masterfrom Jul 14, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes an out-of-bounds access in blake2b_final by tightening the buffer-length check and using a safe copy function for overlapping memory regions.
- Changed the boundary condition to reject more than one full block leftover.
- Swapped
XMEMCPYforXMEMMOVEto safely handle overlapping buffer regions.
Comments suppressed due to low confidence (2)
wolfcrypt/src/blake2b.c:359
- The new boundary check for leftover bytes isn't covered by existing tests. Add unit tests for cases where
buflenis just above and just belowBLAKE2B_BLOCKBYTESto ensure correct behavior.
if ( S->buflen > BLAKE2B_BLOCKBYTES )
wolfcrypt/src/blake2b.c:361
- [nitpick] Please update the function’s doxygen or inline comments to explain why
XMEMMOVEis used instead ofXMEMCPY, clarifying the need for safe overlapping memory copies.
XMEMMOVE( S->buf, S->buf + BLAKE2B_BLOCKBYTES, (wolfssl_word)S->buflen );
Member
Author
|
Retest this please |
rlm2002
approved these changes
Jul 14, 2025
JacobBarthelmeh
approved these changes
Jul 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Coverity confirmed
Checklist