SSL_read_ex() ... will return 1 for success or 0 for failure

[effbiae]

Description

wolfSSL_read_ex() was returning bytes read instead of success/failure.

see man page for SSL_read_ex for compatible behaviour

Testing

without this change:

$ ./tests/unit.test 2>&1 |grep wolfSSL_read_ex -B1 -A1
ERROR - tests/api.c line 9470 failed with:
    expected: wolfSSL_read_ex(ssl_s, buf, sizeof(buf), &count) == WOLFSSL_SUCCESS
    result:   5 != 1

with this change

$ ./tests/unit.test 2>&1 |grep wolfSSL_read_ex -B1 -A1
[no output]

note the relevant test (tests/api.c:test_wolfSSL_read_write_ex()) fails but force returns TEST_SUCCESS

[wolfSSL-Bot]

Can one of the admins verify this patch?

[dgarske]

Okay to test. Contributor agreement on file. Thank you @effbiae this appears to be a good fix!

[dgarske]

Hi @effbiae , the Espressif error is not related to your PR. We are working on a resolution, but I won't let it hold up this PR.

wrong account

[dgarske]

Jenkins retest this please: "AgentOfflineException"