Add message order sanity checks#9267
Merged
dgarske merged 8 commits intowolfSSL:masterfrom Oct 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
src/internal.c:1
- Missing space before the logical OR operator.
/* internal.c
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
julek-wolfssl
force-pushed
the
dtls-stricter-ordering
branch
from
23d3848 to
c623179
Compare
rizlik
requested changes
Oct 6, 2025
Contributor
rizlik
left a comment
rizlik
left a comment
There was a problem hiding this comment.
I don't see any reason why this bug should be dtls-specific. Can you move the test in a more general place and remove the dtls dependency?
julek-wolfssl
force-pushed
the
dtls-stricter-ordering
branch
from
c623179 to
7afbb81
Compare
gasbytes
reviewed
Oct 7, 2025
rizlik
previously approved these changes
Oct 7, 2025
julek-wolfssl
force-pushed
the
dtls-stricter-ordering
branch
3 times, most recently
from
4e33f07 to
9a5d00f
Compare
Reorganize test_dtls tests to use TEST_DECL_GROUP Reorganize test_tls tests to use TEST_DECL_GROUP
julek-wolfssl
force-pushed
the
dtls-stricter-ordering
branch
from
2b87193 to
10365d6
Compare
rizlik
requested changes
Oct 8, 2025
Member
Author
|
Retest this please openssl.test failed. |
rizlik
previously approved these changes
Oct 8, 2025
gasbytes
previously approved these changes
Oct 8, 2025
dgarske
requested changes
Oct 8, 2025
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Nice work! Just one question about the mutual auth side.
Member
|
Jenkins retest this please |
dgarske
approved these changes
Oct 9, 2025
dgarske
requested changes
Oct 9, 2025
dgarske
requested changes
Oct 9, 2025
julek-wolfssl
force-pushed
the
dtls-stricter-ordering
branch
from
30eb2df to
5efdc6b
Compare
dgarske
previously approved these changes
Oct 9, 2025
Member
|
Jenkins retest this please. FIPS test issues |
dgarske
approved these changes
Oct 10, 2025
Member
|
Jenkins retest this please: "FIPSv2-regression". Please someone investigate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganize test_dtls tests to use TEST_DECL_GROUP