Skip to content

testsuite_test: reset ready in between uses#9279

Merged
dgarske merged 1 commit intowolfSSL:masterfrom
julek-wolfssl:testsuite_test-ready
Oct 7, 2025
Merged

testsuite_test: reset ready in between uses#9279
dgarske merged 1 commit intowolfSSL:masterfrom
julek-wolfssl:testsuite_test-ready

Conversation

@julek-wolfssl
Copy link
Copy Markdown
Member

This should fix the constant intermittent failures in GH CI.

This should fix the constant intermittent failures in GH CI.
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🛟 Devin Lifeguard found 2 likely issues in this PR

  • check-all-return-codes snippet snippet: Capture and check the return value of the new fprintf calls (e.g., if (fprintf(stderr, "connecting to %s:%d\n", ip, port) < 0) err_sys_with_errno("fprintf failed");) to ensure write errors are detected.
  • check-return-codes snippet snippet: Check the definitions of FreeTcpReady() and InitTcpReady(); if either returns a status (e.g., int) indicating failure, capture the return value and handle or propagate it instead of ignoring it.

@julek-wolfssl
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

Copy link
Copy Markdown
Member

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@dgarske
Copy link
Copy Markdown
Member

dgarske commented Oct 7, 2025

Jenkins retest this please. FIPS test failure, no history kept (again, FIPS tests in Jenkins aren't keeping very many histories).

@dgarske dgarske merged commit 1d67e55 into wolfSSL:master Oct 7, 2025
260 of 261 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants