Skip to content

Fixes for Ed25519 raw key import with C# wrapper#9291

Merged
dgarske merged 2 commits intowolfSSL:masterfrom
JacobBarthelmeh:csharp
Oct 13, 2025
Merged

Fixes for Ed25519 raw key import with C# wrapper#9291
dgarske merged 2 commits intowolfSSL:masterfrom
JacobBarthelmeh:csharp

Conversation

@JacobBarthelmeh
Copy link
Copy Markdown
Contributor

ZD20644

@JacobBarthelmeh JacobBarthelmeh self-assigned this Oct 10, 2025
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🛟 Devin Lifeguard found 1 likely issues in this PR

  • check-all-return-codes snippet snippet: After each call (e.g., ret = wolfcrypt.Ed25519ImportPublic(...) or wc_ed25519_delete(...)) add if (ret != 0) { /* handle or throw */ } to ensure the return code is checked and errors are handled.

@JacobBarthelmeh
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

@JacobBarthelmeh
Copy link
Copy Markdown
Contributor Author

Retest this please Jenkins.

Aarch64 test ERROR: Error fetching remote repo 'origin'

@dgarske dgarske requested a review from aidangarske October 13, 2025 18:25
Copy link
Copy Markdown
Member

@aidangarske aidangarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me thanks

@dgarske dgarske merged commit 4f0836e into wolfSSL:master Oct 13, 2025
258 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants