Fix GCC warnings#9292
Merged
douzzer merged 8 commits intowolfSSL:masterfrom Oct 14, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes GCC compiler warnings when strict rules are enabled, addressing customer-reported issues in ticket zd20626.
- Added proper const qualifier to function parameter to fix const-correctness warnings
- Implemented bounds checking for indent parameters to prevent format truncation warnings
- Fixed code structure issues including unreachable code and duplicated branch warnings
- Added pragma directives to suppress intentional duplicated branch warning
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| wolfcrypt/src/evp.c | Added const qualifier to src parameter in EvpCipherAesGCM function |
| src/x509.c | Added MAX_INDENT constant and bounds checking for indent parameters across multiple print functions |
| src/tls.c | Fixed unreachable code by adding proper null check and control flow for TLSX_Find result |
| src/ssl_bn.c | Added GCC pragma to suppress intentional duplicated branches warning |
| src/pk.c | Added bounds checking for indent parameter to prevent format truncation |
| src/internal.c | Removed duplicate conditional code blocks that were causing compiler warnings |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
douzzer
approved these changes
Oct 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Customer reported warnings with strict rules enabled
Fixes zd20626
Testing
Tool confirmed
Checklist