Skip to content

refactor wolfSSL_CTX_set_srp_username#9301

Merged
dgarske merged 1 commit intowolfSSL:masterfrom
effbiae:set_srp_username
Oct 16, 2025
Merged

refactor wolfSSL_CTX_set_srp_username#9301
dgarske merged 1 commit intowolfSSL:masterfrom
effbiae:set_srp_username

Conversation

@effbiae
Copy link
Copy Markdown
Contributor

@effbiae effbiae commented Oct 15, 2025

Description

have wolfSSL_CTX_set_srp_username() call wolfSSL_CTX_set_srp_password() instead of duplicating code.

Testing

./configure --enable-opensslextra --enable-srp --enable-all && make check

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

🛟 Devin Lifeguard found 1 likely issues in this PR

  • free-allocated-memory snippet: Verify in wolfSSL_CTX_set_srp_password() whether ctx->srp_password is freed/re-used; if not, restore the XFREE(ctx->srp_password, ctx->heap, DYNAMIC_TYPE_SRP) after the helper call to avoid leaking the earlier allocation.

@effbiae
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

@wolfSSL-Bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@dgarske
Copy link
Copy Markdown
Member

dgarske commented Oct 15, 2025

Okay to test. Contributor agreement on file.

@dgarske
Copy link
Copy Markdown
Member

dgarske commented Oct 15, 2025

Jenkins retest this please. FIPS v2 PAA error (not related to PR and is intermittent).

@dgarske dgarske removed their assignment Oct 15, 2025
@dgarske dgarske requested a review from SparkiDev October 15, 2025 15:28
Copy link
Copy Markdown
Contributor

@SparkiDev SparkiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a funny in wolfSSL_CTX_set_srp_password when comparing the code.
Please fix that too.

Comment thread src/ssl.c
@dgarske dgarske requested a review from SparkiDev October 16, 2025 15:18
@dgarske dgarske merged commit a22d239 into wolfSSL:master Oct 16, 2025
344 of 346 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants