Skip to content

Regression testing#9311

Merged
dgarske merged 1 commit intowolfSSL:masterfrom
SparkiDev:regression_fixes_19
Oct 16, 2025
Merged

Regression testing#9311
dgarske merged 1 commit intowolfSSL:masterfrom
SparkiDev:regression_fixes_19

Conversation

@SparkiDev
Copy link
Copy Markdown
Contributor

Description

x509.c: realloc may fail and therefore need to store result in a temporary so the old pointer is not lost.

tls.c: free the name if it is not pushed on to the stack of peer CA names. Failure to push can be from memory allocation failure.

aes.c: Don't compile XTS decrypt functions without HAVE_AES_DECRYPT.

Fix tests to have better pre-processor protection.

Testing

Regression testing.

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

x509.c: realloc may fail and therefore need to store result in a
temporary so the old pointer is not lost.

tls.c: free the name if it is not pushed on to the stack of peer CA
names. Failure to push can be from memory allocation failure.

aes.c: Don't compile XTS decrypt functions without HAVE_AES_DECRYPT.

Fix tests to have better pre-processor protection.
@SparkiDev SparkiDev self-assigned this Oct 16, 2025
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🛟 Devin Lifeguard found 1 likely issues in this PR

  • check-all-return-codes snippet: Determine SetDH’s return type; if it returns an error/status code, add an assertion or error-handling check after the call (e.g., AssertIntEQ(SetDH(ssl_srv), 0);).

@SparkiDev
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

@SparkiDev
Copy link
Copy Markdown
Contributor Author

SparkiDev commented Oct 16, 2025

retest this please

. /host/pkgs/sdk-arm_24.60372.0/environment-setup-cortexa8hf-neon-poky-linux-gnueabi
Running configure script...
configure: error: unrecognized options: --with-libtool-sysroot
CONFIG RESULT = 1
Configuration Failed
�[1;31mError: OE2: without PAA test failed�[0m
[twice]

@SparkiDev SparkiDev assigned wolfSSL-Bot and unassigned SparkiDev Oct 16, 2025
@SparkiDev SparkiDev requested a review from wolfSSL-Bot October 16, 2025 05:57
@SparkiDev
Copy link
Copy Markdown
Contributor Author

🛟 Devin Lifeguard found 1 likely issues in this PR

* `check-all-return-codes` [snippet](https://github.com/wolfSSL/wolfssl/blob/c111c5baccecd9c17a348a4543074be9debcfe16/tests/api/test_tls_ext.c#L280): Determine SetDH’s return type; if it returns an error/status code, add an assertion or error-handling check after the call (e.g., AssertIntEQ(SetDH(ssl_srv), 0);).

@SparkiDev please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

SetDH has void return

@dgarske dgarske merged commit d88ab84 into wolfSSL:master Oct 16, 2025
337 of 338 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants