Skip to content

refactor to EcExportHsKey#9349

Merged
douzzer merged 1 commit intowolfSSL:masterfrom
effbiae:EcExportHsKey
Oct 31, 2025
Merged

refactor to EcExportHsKey#9349
douzzer merged 1 commit intowolfSSL:masterfrom
effbiae:EcExportHsKey

Conversation

@effbiae
Copy link
Copy Markdown
Contributor

@effbiae effbiae commented Oct 26, 2025

Description

refactor duplicate code to EcExportHsKey()

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

🛟 Devin Lifeguard found 1 likely issues in this PR

  • check-all-return-codes snippet: Inspect the code paths after the switch-case in SendClientKeyExchange() to verify that the return value ‘ret’ set by EcExportHsKey is examined and, if negative, causes the function to abort; add an explicit “if (ret != 0) { ERROR_OUT(ECC_EXPORT_ERROR, exit_scke); }” immediately after the EcExportHsKey call if such a check does not already exist later.

@effbiae
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

@wolfSSL-Bot
Copy link
Copy Markdown

Can one of the admins verify this patch?

@dgarske
Copy link
Copy Markdown
Member

dgarske commented Oct 27, 2025

Okay to test. Contributor agreement on file. Thank you @effbiae

Comment thread src/internal.c
@dgarske
Copy link
Copy Markdown
Member

dgarske commented Oct 28, 2025

Jenkins retest this please "FIPS v2 test"

@douzzer douzzer merged commit 9c03160 into wolfSSL:master Oct 31, 2025
268 of 269 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants