Check for duplicate extensions in client hello when HAVE_TLS_EXTENSIONS is not set - fix #9377#9391
Merged
dgarske merged 3 commits intowolfSSL:masterfrom Nov 11, 2025
Merged
Conversation
Contributor
|
🛟 Devin Lifeguard found 1 likely issues in this PR
@holtrop |
SparkiDev
requested changes
Nov 5, 2025
…NS is not set - fix wolfSSL#9377
holtrop
force-pushed
the
check-dup-extensions-fix
branch
from
e7b4fcf to
3af60ff
Compare
SparkiDev
previously approved these changes
Nov 11, 2025
dgarske
requested changes
Nov 11, 2025
holtrop
force-pushed
the
check-dup-extensions-fix
branch
from
553df37 to
32b00fd
Compare
Member
|
Jenkins retest this please |
dgarske
approved these changes
Nov 11, 2025
dgarske
requested changes
Nov 11, 2025
dgarske
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check for duplicate extensions in client hello when HAVE_TLS_EXTENSIONS is not set - fix #9377
Testing
Ran reproduce steps from #9377 and verified the duplicate error is now found.
Ran unit tests for configuration
./configure --disable-sni --disable-ecc --disable-tls13 --disable-secure-renegotiation-info(prior to this fix thetest_tls_ext_duplicatetest was failing to correctly detect the duplicate extension for this configuration).Checklist