-
Notifications
You must be signed in to change notification settings - Fork 923
Rust wrapper: support optional heap and dev_id parameters #9407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
retest this please |
|
🛟 Devin Lifeguard found 1 likely issues in this PR
@holtrop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor documentation inconsistency, the rest LGTM.
I guess the only thing that comes to mind is probably we could add in the documentation of the heap argument that the pointer must remain valid for the lifetime of the object (?) though this is pretty niche and what constitute a valid heap argument.
Description
Rust wrapper: support optional heap and dev_id parameters
Testing
How did you test?
Checklist