Skip to content

Conversation

@holtrop
Copy link

@holtrop holtrop commented Nov 10, 2025

Description

Rust wrapper: support optional heap and dev_id parameters

Testing

How did you test?

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@holtrop holtrop self-assigned this Nov 10, 2025
@holtrop holtrop requested a review from gasbytes November 10, 2025 18:58
@holtrop
Copy link
Author

holtrop commented Nov 10, 2025

retest this please

@holtrop holtrop marked this pull request as ready for review November 11, 2025 16:36
@holtrop holtrop assigned wolfSSL-Bot and unassigned holtrop Nov 11, 2025
@devin-ai-integration
Copy link
Contributor

🛟 Devin Lifeguard found 1 likely issues in this PR

  • do-not-change-external-apis snippet snippet snippet snippet: Restore the original no-argument public functions (e.g., keep pub fn new() -> Result<Self,i32>) and have them internally call the newly-introduced extended versions (new_ex(heap, dev_id)) with default None/INVALID_DEVID values, while leaving the extended APIs as the new optional variants.

@holtrop
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

@gasbytes gasbytes self-assigned this Nov 11, 2025
gasbytes
gasbytes previously approved these changes Nov 11, 2025
@gasbytes gasbytes removed their assignment Nov 11, 2025
@holtrop holtrop requested a review from dgarske November 12, 2025 15:32
@holtrop holtrop removed their assignment Nov 12, 2025
dgarske
dgarske previously approved these changes Nov 12, 2025
@dgarske dgarske requested a review from gasbytes November 12, 2025 16:17
@dgarske dgarske added the For This Release Release version 5.8.4 label Nov 12, 2025
Copy link
Contributor

@gasbytes gasbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor documentation inconsistency, the rest LGTM.

I guess the only thing that comes to mind is probably we could add in the documentation of the heap argument that the pointer must remain valid for the lifetime of the object (?) though this is pretty niche and what constitute a valid heap argument.

@holtrop holtrop requested a review from gasbytes November 12, 2025 18:41
@dgarske dgarske self-requested a review November 12, 2025 19:18
@dgarske dgarske merged commit e78752f into wolfSSL:master Nov 12, 2025
264 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.8.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants