ECC sign hash: only allow up to max digest size#9422
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Nov 13, 2025
Merged
Conversation
SparkiDev
force-pushed
the
ecc_sign_hash_inlen_check
branch
from
99e0458 to
f7cc473
Compare
Validate that the hash passed in is of an appropriate length - not greater than the maximum digest size.
SparkiDev
force-pushed
the
ecc_sign_hash_inlen_check
branch
from
f7cc473 to
6c30186
Compare
DrKatieL
approved these changes
Nov 13, 2025
DrKatieL
left a comment
DrKatieL
left a comment
There was a problem hiding this comment.
Changes look to address the issue. Fix passed tests mentioned in the issue and wolfcrypt/test/test.c tests.
dgarske
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Validate that the hash passed in is of an appropriate length - not greater than the maximum digest size.
Fixes #9417
Testing
Standard testing.
Checklist