20251125-aes-arm-fixes#9475
Merged
anhu merged 1 commit intowolfSSL:masterfrom Nov 26, 2025
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
Contributor
Author
|
retest this please |
anhu
reviewed
Nov 25, 2025
Member
anhu
left a comment
anhu
left a comment
There was a problem hiding this comment.
LGTM , on to SparkiDev for the real review.
anhu
previously approved these changes
Nov 25, 2025
SparkiDev
previously requested changes
Nov 26, 2025
…__ static C implementation of GCM_gmult_len(), rename to GCM_gmult_len_armasm_C() (incompatible with other implementations); wolfcrypt/src/aes.c: move FREESCALE_MMCAU implementations later (minimum precedence) for wc_AesEncrypt(), wc_AesDecrypt(), wc_AesSetKeyLocal(), wc_AesSetKey(), and wc_AesSetKeyDirect() (fixes ZD#20862).
douzzer
force-pushed
the
20251125-aes-arm-fixes
branch
from
25a8cfe to
be1f916
Compare
Contributor
Author
|
retest this please |
anhu
approved these changes
Nov 26, 2025
douzzer
dismissed
SparkiDev’s stale review
fixed (removed offending changes)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfcrypt/src/aes.c: in theWOLFSSL_ARMASM&&GCM_SMALL&& !__aarch64__staticC implementation ofGCM_gmult_len(), rename toGCM_gmult_len_armasm_C()(incompatible with other implementations);wolfcrypt/src/aes.c: moveFREESCALE_MMCAUimplementations later (minimum precedence) forwc_AesEncrypt(),wc_AesDecrypt(),wc_AesSetKeyLocal(),wc_AesSetKey(), andwc_AesSetKeyDirect()(fixes ZD#20862).tested with