ML-DSA/Dilithium: reduce vector when small build#9760
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Feb 18, 2026
Merged
Conversation
SparkiDev
force-pushed
the
mldsa_small_matrix_mul_reduce
branch
2 times, most recently
from
3937a4f to
614aa74
Compare
Ensure the matrix multiplication result has values reduced to the correct range. Only an issue for small builds.
SparkiDev
force-pushed
the
mldsa_small_matrix_mul_reduce
branch
from
614aa74 to
895fb29
Compare
programsurf
approved these changes
Feb 18, 2026
programsurf
left a comment
programsurf
left a comment
There was a problem hiding this comment.
LGTM. The fix correctly adds dilithium_vec_red() after matrix_mul at all affected sites, properly guarded by WOLFSSL_DILITHIUM_SMALL. This matches the pq-crystals reference pattern. Clean and minimal fix — nicely done.
dgarske
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ensure the matrix multiplication result has values reduced to the correct range. Only an issue for small builds.
Fixes zd#21168
Testing
Standard