Skip to content

harden compare of mac with TLS 1.3 finished#9864

Merged
douzzer merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh:f11
Mar 5, 2026
Merged

harden compare of mac with TLS 1.3 finished#9864
douzzer merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh:f11

Conversation

@JacobBarthelmeh
Copy link
Copy Markdown
Contributor

F-11

@JacobBarthelmeh JacobBarthelmeh self-assigned this Mar 4, 2026
Copilot AI review requested due to automatic review settings March 4, 2026 17:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Hardens TLS 1.3 Finished verify-data comparison to reduce timing side-channel risk.

Changes:

  • Replaced XMEMCMP with ConstantCompare when validating TLS 1.3 Finished verify-data.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/tls13.c
@JacobBarthelmeh
Copy link
Copy Markdown
Contributor Author

Retest this please Jenkins

PRB-140-3-tests failure

@douzzer douzzer added the Staged Staged for merge pending final test results and review label Mar 5, 2026
@douzzer douzzer merged commit 90ca9c4 into wolfSSL:master Mar 5, 2026
451 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Staged Staged for merge pending final test results and review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants