Add missing ForceZero calls#9885
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Mar 11, 2026
Merged
Conversation
Frauschi
force-pushed
the
missing_force_zero
branch
from
f1a0807 to
c577968
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit zeroization of sensitive buffers (ForceZero + optional wc_MemZero_Check) to address several missing wipe sites across TLS 1.2/1.3 key derivation paths.
Changes:
- Ensure temporary key material in TLS 1.3 secret derivation is wiped before returning.
- Wipe PRF/key-derivation intermediate buffers in TLS 1.2/legacy paths before freeing.
- Introduce misc include plumbing in
keys.cto makeForceZeroavailable.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/tls13.c | Adds cleanup path to wipe derived key buffer(s) in TLS 1.3 secret derivation. |
| src/tls.c | Wipes PRF digest buffer before freeing in TLS key derivation. |
| src/keys.c | Wipes multiple TLS 1.0–1.2 derivation intermediates; replaces manual loops with ForceZero; adds ForceZero include wiring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SparkiDev
reviewed
Mar 5, 2026
Frauschi
force-pushed
the
missing_force_zero
branch
from
c577968 to
e615773
Compare
Frauschi
force-pushed
the
missing_force_zero
branch
from
e615773 to
001eae7
Compare
douzzer
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-13, F-14, F-197, F-198, F-199, and F-200. All at once as these are very similar.