Hardening in wc_FreeRsaKey and wc_RsaPrivateKeyDecodeRaw#9893
Merged
douzzer merged 3 commits intowolfSSL:masterfrom Mar 7, 2026
Merged
Hardening in wc_FreeRsaKey and wc_RsaPrivateKeyDecodeRaw#9893douzzer merged 3 commits intowolfSSL:masterfrom
douzzer merged 3 commits intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens RSA key cleanup paths by always zeroizing private key material (even when key->type is not RSA_PRIVATE), reducing the risk of residual sensitive data after partial operations/failures.
Changes:
- Update
wc_FreeRsaKeyto unconditionallymp_forcezeroprivate-key fields instead of switching betweenmp_forcezeroandmp_clearbased onkey->type. - Update
wc_RsaPrivateKeyDecodeRawfailure/cleanup path tomp_forcezeroprivate components (d,p,q, etc.) instead ofmp_clear.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Jenkins retest this please |
Member
Author
|
Retest this please |
douzzer
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use force zero to harden RSA operations
Fixes:
Checklist