Address final comments from #9761#9958
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Mar 12, 2026
Merged
Conversation
- Fix line length - Remove duplicate comment - Check return of `wc_HashGetDigestSize` - Use constant instead of magic number
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses cleanup comments from a previous PR (#9761), making small formatting and correctness improvements across three files in the wolfSSL codebase.
Changes:
- Added a return value check for
wc_HashGetDigestSizein the OCSP request/response comparison function to handle invalid hash algorithms gracefully. - Replaced the magic number
0xFFFFwith the defined constantWOLFSSL_MAX_16BITin TLS 1.3 CSR buffer size validation. - Fixed line lengths exceeding the project's limit and removed a duplicate comment in the OCSP responder example.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wolfcrypt/src/asn.c | Added error check for wc_HashGetDigestSize return value in CompareOcspReqResp |
| src/tls13.c | Replaced 0xFFFF magic number with WOLFSSL_MAX_16BIT constant |
| examples/ocsp_responder/ocsp_responder.c | Line length fixes, removed duplicate "Usage help" comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
JacobBarthelmeh
approved these changes
Mar 12, 2026
Contributor
|
Retest this please Jenkins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wc_HashGetDigestSize