Skip to content

protoc-gen-go-grpc: fix build to compile the CLI#19530

Merged
ajayk merged 2 commits into
wolfi-dev:mainfrom
vito:patch-1
May 15, 2024
Merged

protoc-gen-go-grpc: fix build to compile the CLI#19530
ajayk merged 2 commits into
wolfi-dev:mainfrom
vito:patch-1

Conversation

@vito
Copy link
Copy Markdown
Contributor

@vito vito commented May 15, 2024

Related: #19132 (introduced regression)

Currently the protoc-gen-go-grpc package installs the library as /usr/bin/protoc-gen-go-grpc instead of the CLI as it did before. Seems like a simple oversight from the broader refactor.

Copy link
Copy Markdown
Member

@ajayk ajayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to epoch bump

@vito
Copy link
Copy Markdown
Contributor Author

vito commented May 15, 2024

@ajayk Whoops, fixed - thanks for the quick review!

edit: err, sorry for the ping, just saw the CI failures, which look legit

Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Copy link
Copy Markdown
Member

@ajayk ajayk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a basic test , here is something you can use which avoids further breakage of packages

test:
  pipeline:
    - runs: |
        protoc-gen-go-grpc --version

Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
@vito
Copy link
Copy Markdown
Contributor Author

vito commented May 15, 2024

@ajayk Absolutely - just added, thanks. Not sure how to run the test, but I manually verified by following the CONTRIBUTING.md. 👍

@ajayk
Copy link
Copy Markdown
Member

ajayk commented May 15, 2024

@ajayk Absolutely - just added, thanks. Not sure how to run the test, but I manually verified by following the CONTRIBUTING.md. 👍

if you check the builds logs here is a an example of running in a test , I will add the running tests to the docs

/usr/bin/melange test ./protoc-gen-go-grpc.yaml --source-dir ./protoc-gen-go-grpc --repository-append ./packages --keyring-append local-melange.rsa.pub --arch aarch64 --pipeline-dirs ./pipelines/ --repository-append https://packages.wolfi.dev/os --keyring-append https://packages.wolfi.dev/os/wolfi-signing.rsa.pub --test-package-append wolfi-base --debug --runner docker --log-policy builtin:stderr

Test output here

2024/05/15 21:57:49 INFO running the main test pipeline
2024/05/15 21:57:49 WARN + export 'PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'
2024/05/15 21:57:49 WARN + '[' -d /home/build ]
2024/05/15 21:57:49 WARN + cd /home/build
2024/05/15 21:57:49 WARN + protoc-gen-go-grpc --version
2024/05/15 21:57:49 INFO protoc-gen-go-grpc 1.3.0
2024/05/15 21:57:49 WARN + exit 0
2024/05/15 21:57:49 INFO pod 84454af44d1f07a3136938b65797bfb99025f299466d2c6e6beed9bd50c8aced terminated

@ajayk ajayk enabled auto-merge May 15, 2024 22:02
@ajayk ajayk merged commit eda5d7e into wolfi-dev:main May 15, 2024
@vito vito deleted the patch-1 branch May 15, 2024 22:03
justinvreeland pushed a commit to justinvreeland/wolfi that referenced this pull request May 6, 2026
Co-authored-by: staging-vpa-bot <staging-vpa-bot@chainguard.dev>

Export:  622dfe8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants