protoc-gen-go-grpc: fix build to compile the CLI#19530
Merged
Merged
Conversation
Contributor
Author
|
@ajayk Whoops, fixed - thanks for the quick review! edit: err, sorry for the ping, just saw the CI failures, which look legit |
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
ajayk
reviewed
May 15, 2024
Member
ajayk
left a comment
There was a problem hiding this comment.
Can we add a basic test , here is something you can use which avoids further breakage of packages
test:
pipeline:
- runs: |
protoc-gen-go-grpc --version
Signed-off-by: Alex Suraci <suraci.alex@gmail.com>
Contributor
Author
|
@ajayk Absolutely - just added, thanks. Not sure how to run the test, but I manually verified by following the |
Member
if you check the builds logs here is a an example of running in a test , I will add the running tests to the docs Test output here |
ajayk
approved these changes
May 15, 2024
justinvreeland
pushed a commit
to justinvreeland/wolfi
that referenced
this pull request
May 6, 2026
Co-authored-by: staging-vpa-bot <staging-vpa-bot@chainguard.dev> Export: 622dfe8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #19132 (introduced regression)
Currently the
protoc-gen-go-grpcpackage installs the library as/usr/bin/protoc-gen-go-grpcinstead of the CLI as it did before. Seems like a simple oversight from the broader refactor.