glibc: better support ldconfig trigger with different shells#45154
Merged
Conversation
octo-sts
Bot
added
the
bincapz/pass
apk-tools orders triggers in runtime dependency order, meaning glibc trigger is guaranteed to execute before busybox trigger sets up "sh" symlink. Move glibc trigger to apk-tools post-commit hook, such that it is executed after all triggers have been fired, to ensure shell is accessible. Separately, will submit glibc upstream feature change to make it possible to use "#!/usr/bin/ldconfig.trigger" as a trigger which ignores all arguments. Add test cases to verify that bootstraps work with various shells.
xnox
force-pushed
the
scriplet-more-fixes
branch
from
1c90c0f to
d931eb2
Compare
Member
Author
|
@dannf there was lint failure, which is now fixed. Please re-review. |
dannf
approved these changes
Mar 7, 2025
Member
|
approved :) but maybe wait until Monday to merge? |
Member
Author
we do release to prod on Fridays =) |
jakeva
pushed a commit
to jakeva/os
that referenced
this pull request
Mar 23, 2026
Co-authored-by: staging-update-bot <staging-update-bot@chainguard.dev> Export: dc8777c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apk-tools orders triggers in runtime dependency order, meaning glibc
trigger is guaranteed to execute before busybox trigger sets up "sh"
symlink.
Move glibc trigger to apk-tools post-commit hook, such that it is
executed after all triggers have been fired, to ensure shell is
accessible.
Separately, will submit glibc upstream feature change to make it
possible to use "#!/usr/bin/ldconfig.trigger" as a trigger which
ignores all arguments.
Add test cases to verify that bootstraps work with various shells.