Skip to content

Conversation

@javacruft
Copy link
Member

@javacruft javacruft commented Apr 11, 2025

GPT fdisk provides partitioning tools for GPT block devices; used by ceph via the sgdisk binary which is great for script usage.

Includes a patch from Alpine for include paths and a linking issue seen in Wolfi; package lacks any configure command and the upstream Makefile is primitive.

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

GPT fdisk provides partitioning tools for GPT block devices; used
by ceph via the sgdisk binary which is great for script usage.

Includes a patch from Alpine for include paths and a linking issue
seen in Wolfi; package lacks any configure command and the upstream
Makefile is primitive.

Signed-off-by: James Page <james.page@chainguard.dev>
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Apr 11, 2025
Signed-off-by: James Page <james.page@chainguard.dev>
@javacruft javacruft requested a review from a team April 11, 2025 09:07
@javacruft javacruft enabled auto-merge April 11, 2025 12:33
@kbsteere kbsteere merged commit 5c3f1c0 into wolfi-dev:main Apr 11, 2025
15 checks passed
@javacruft javacruft deleted the new/gdisk branch June 12, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants