Closed
Conversation
Signed-off-by: Michael Paul <31833332+MickeyPvX@users.noreply.github.com>
Signed-off-by: Michael Paul <31833332+MickeyPvX@users.noreply.github.com>
octo-sts
Bot
added
the
bincapz/pass
maxgio92
reviewed
Oct 1, 2025
| vars: | ||
| # OpenTelemetry commit SHA compatible with nginx mainline | ||
| # Based on latest nginx tag from opentelemetry-cpp-contrib | ||
| otel-sha: "5be4b76ebf67fee4d09f897649fd8d9348ba5d73" |
Member
There was a problem hiding this comment.
Would it be possible to check that the supported version is aligned with nginx upstream, like we did for ingress-nginx-controller/otel-plugin here 78949bc?
If so, it would prevent us from building unsupported or old versions of the plugin.
Member
Author
There was a problem hiding this comment.
So I'm just coming across what I think is the proper nginx-otel package...which is not the opentelemetry one...this may need a redo, so I'm going to put this into draft while I sort this out 🤦
maxgio92
reviewed
Oct 1, 2025
| - curl-dev | ||
| - gd-dev | ||
| - geoip-dev | ||
| - git |
Member
There was a problem hiding this comment.
Optionally we can omit it since git-checkout brings it.
maxgio92
reviewed
Oct 1, 2025
| - curl-dev | ||
| - gd-dev | ||
| - geoip-dev | ||
| - git |
Member
There was a problem hiding this comment.
Optionally we can omit it since git-checkout brings it.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds the
nginx-mod-otelsubpackage.Related: https://github.com/chainguard-dev/image-requests/issues/7001