Conversation
copying what was done in nginx-ingress
| - uses: git-checkout | ||
| with: | ||
| repository: https://github.com/google/ngx_brotli.git | ||
| branch: master | ||
| expected-commit: a71f9312c2deb28875acc7bacfdd5695a111aa53 | ||
| destination: ngx_brotli |
There was a problem hiding this comment.
I think this should probably change to be
- runs: |
git clone https://github.com/google/ngx_brotli.git
git checkout a71f9312c2deb28875acc7bacfdd5695a111aa53
Otherwise the next time this build runs the expected commit sha will not match and the build will fail.
Unfortunately we don't have an automated way to handle keeping multiple git-checkout.
There was a problem hiding this comment.
Thinking about it a bit more, a better solution would probably be to create a new ngx_brotli package and add a environment.contents.packages dependency for the new ngx_brotli which can then be used for --add-dynamic-module=./ngx_brotli
There was a problem hiding this comment.
@vr did you want to try that? I'm happy to if you prefer, up to you. This way both nginx-mainline and nginx-ingress can share the same ngx_brotli package.
There was a problem hiding this comment.
i'm not sure you can build once for both nginx version 🤔
There was a problem hiding this comment.
and i was not able to directly use git without having uses: git-checkout before because git command was not available before
rawlingsj
added
the
blocked
rawlingsj
removed
the
blocked
|
This Pull Request is stale because it has been open for 90 days with |
Add ngx_brotli as a build-time dependency and emit two new dynamic
module subpackages (nginx-{mainline,stable}-mod-http_brotli_filter
and -static) via the existing range: modules loop.
The ngx_brotli sources are consumed from /usr/src/ngx_brotli
(provided by the new ngx_brotli source-only package) rather than
fetched inline, matching the pattern used by njs consuming
nginx-src-main. This structure lets nginx-mainline, nginx-stable,
and downstream consumers (e.g. ingress-nginx-controller) share the
same ngx_brotli pin via a single package.
Revives wolfi-dev#8771, addressing @rawlingsj's review feedback that
suggested packaging ngx_brotli separately.
Refs: wolfi-dev#8771
Add ngx_brotli as a build-time dependency and emit two new dynamic
module subpackages (nginx-{mainline,stable}-mod-http_brotli_filter
and -static) via the existing range: modules loop.
The ngx_brotli sources are consumed from /usr/src/ngx_brotli
(provided by the new ngx_brotli source-only package) rather than
fetched inline, matching the pattern used by njs consuming
nginx-src-main. This structure lets nginx-mainline, nginx-stable,
and downstream consumers (e.g. ingress-nginx-controller) share the
same ngx_brotli pin via a single package.
Revives wolfi-dev#8771, addressing @rawlingsj's review feedback that
suggested packaging ngx_brotli separately.
Refs: wolfi-dev#8771
Add ngx_brotli as a build-time dependency and emit two new dynamic
module subpackages (nginx-{mainline,stable}-mod-http_brotli_filter
and -static) via the existing range: modules loop.
The ngx_brotli sources are consumed from /usr/src/ngx_brotli
(provided by the new ngx_brotli source-only package) rather than
fetched inline, matching the pattern used by njs consuming
nginx-src-main. This structure lets nginx-mainline, nginx-stable,
and downstream consumers (e.g. ingress-nginx-controller) share the
same ngx_brotli pin via a single package.
Revives wolfi-dev#8771, addressing @rawlingsj's review feedback that
suggested packaging ngx_brotli separately.
Refs: wolfi-dev#8771
2 participants
copying what was done in nginx-ingress