-
Notifications
You must be signed in to change notification settings - Fork 136
[Shipping Labels Revamp] Fix Shipping Label package serialization #13059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shipping Labels Revamp] Fix Shipping Label package serialization #13059
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #13059 +/- ##
=========================================
Coverage 40.47% 40.47%
Complexity 6187 6187
=========================================
Files 1287 1287
Lines 74166 74164 -2
Branches 10147 10147
=========================================
Hits 30015 30015
+ Misses 41546 41544 -2
Partials 2605 2605 ☔ View full report in Codecov by Sentry. |
Summary
Finish issue #12284 by adding JSON parsing and mapping resilient to the different responses the Package API might return.
Screen Capture
Screen_recording_20241204_183356.mp4
How to Test
Select PackagebuttonSavedandCarrierPackage options are loading dataUpdate release notes:
RELEASE-NOTES.txtif necessary.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: