Skip to content

Conversation

@ThomazFB
Copy link
Contributor

@ThomazFB ThomazFB commented Dec 3, 2024

Summary

Finish issue #12284 by adding JSON parsing and mapping resilient to the different responses the Package API might return.

Screen Capture

Screen_recording_20241204_183356.mp4

How to Test

  1. Go to the Shipping Labels new feature through an eligible Order
  2. Hit the Select Package button
  3. Verify that both Saved and Carrier Package options are loading data

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

  • The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
  • Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
  • Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on big (tablet) and small (phone) in case of UI changes, and no regressions are added.

@ThomazFB ThomazFB added type: task An internally driven task. feature: shipping labels Related to creating, ordering, or printing shipping labels. labels Dec 3, 2024
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 3, 2024

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commita974349
Direct Downloadwoocommerce-wear-prototype-build-pr13059-a974349.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 3, 2024

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commita974349
Direct Downloadwoocommerce-prototype-build-pr13059-a974349.apk

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review.

Project coverage is 40.47%. Comparing base (f8b3e4b) to head (a974349).
Report is 7 commits behind head on trunk.

Files with missing lines Patch % Lines
...nglabels/packages/networking/CarrierPackageDTOs.kt 0.00% 17 Missing ⚠️
...glabels/packages/networking/PackageResponseDTOs.kt 0.00% 4 Missing ⚠️
...pinglabels/packages/networking/StorePackageDTOs.kt 0.00% 4 Missing ⚠️
...ckages/datasource/WooShippingLabelPackageMapper.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #13059   +/-   ##
=========================================
  Coverage     40.47%   40.47%           
  Complexity     6187     6187           
=========================================
  Files          1287     1287           
  Lines         74166    74164    -2     
  Branches      10147    10147           
=========================================
  Hits          30015    30015           
+ Misses        41546    41544    -2     
  Partials       2605     2605           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThomazFB ThomazFB added this to the 21.3 milestone Dec 4, 2024
@ThomazFB ThomazFB linked an issue Dec 4, 2024 that may be closed by this pull request
@ThomazFB ThomazFB marked this pull request as ready for review December 4, 2024 21:34
@ThomazFB ThomazFB merged commit 2d10aff into trunk Dec 4, 2024
17 checks passed
@ThomazFB ThomazFB deleted the issue/fix-shipping-label-package-serialization branch December 4, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: shipping labels Related to creating, ordering, or printing shipping labels. type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get list of packages

4 participants