-
Couldn't load subscription status.
- Fork 134
Improve the Filters button color in dark mode #14832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Side note - I've noticed the FAB in dark theme has a different content color, not matching the filter button. Not related so I think this would be best in a separate Linear issue?
I noticed that too but wasn’t sure whether to update it. However, since the background is different now and all other purple buttons use white text, I think you’re right, I’ve updated it in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #14832 +/- ##
============================================
- Coverage 38.27% 38.26% -0.01%
+ Complexity 10101 10100 -1
============================================
Files 2131 2131
Lines 120595 120595
Branches 16529 16529
============================================
- Hits 46153 46150 -3
- Misses 69766 69768 +2
- Partials 4676 4677 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes WOOMOB-1548
Description
This updates the color of the Filters buttons on the Orders and Products screens. The active button color now matches the “+” button used on these screens.
Test Steps
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.