-
Notifications
You must be signed in to change notification settings - Fork 134
Fix Interac Refund Flow #14874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Interac Refund Flow #14874
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can not test it as I don't have the card, but the explanation and the code make sense to me
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
|
@malinajirka I tested it with a simulator - works well! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #14874 +/- ##
=========================================
Coverage 38.27% 38.27%
- Complexity 10087 10088 +1
=========================================
Files 2135 2135
Lines 120976 120977 +1
Branches 16565 16565
=========================================
+ Hits 46298 46302 +4
+ Misses 69978 69976 -2
+ Partials 4700 4699 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
#WOOMOB-1623
Description
This is a tricky one. The issue is that when the navigation component returns result from RefundConfirmationDialog to RefundSummaryFragment, it first returns the result and later on performs the actual navigation to the RefundSummaryFragment. However, as the app processes the result it attempts to navigate to
action_refundSummaryFragment_to_cardReaderFlowbut since the navigation component is still on RefundConfirmationDialog the navigation doesn't happen since actionaction_refundSummaryFragment_to_cardReaderFlowis not found for RefundConfirmationDialog.The proper fix would be to move this line to the bottom of the method. However, that's quite a risky change since it changes order throughout the app and we can't be sure it doesn't break anything.
Therefore, I opted for a suboptimal solution that feels significantly safer.
P.S. This issue was likely introduced here when we moved the action from dialog to summary fragment - #14083.
Test Steps
Images/gif
Screen.Recording.2025-10-31.at.9.50.42.mov
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.