Skip to content

Skip instead of throwing error when product id is not found for legacy Ajax add-to-cart #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

Skip instead of throwing error when product id is not found for legacy Ajax add-to-cart #520

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2f6e1a
fix(classic): improve error handling for product ID retrieval in clas…
triple0t Sep 26, 2025
6b1f360
fix(classic): streamline product ID retrieval by removing optional ch…
triple0t Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions assets/js/src/integrations/classic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,11 @@ export function classicTracking(
);

if ( Number.isNaN( productID ) ) {
throw new Error(
// eslint-disable-next-line no-console
console.error(
'Google Analytics for WooCommerce: Could not read product ID from the button given in `added_to_cart` event. Check whether WooCommerce Core events or elements are malformed by other extensions.'
);
return;
}

// If the current product doesn't match search by ID.
Expand Down Expand Up @@ -105,9 +107,11 @@ export function classicTracking(
const productID = parseInt( element.target?.dataset.product_id );

if ( Number.isNaN( productID ) ) {
throw new Error(
// eslint-disable-next-line no-console
console.error(
'Google Analytics for WooCommerce: Could not read product ID from the target element given to remove from cart event. Check whether WooCommerce Core events or elements are malformed by other extensions.'
);
return;
}
getEventHandler( 'remove_from_cart' )( {
product: getProductFromID( productID, products, cart ),
Expand Down