StoresManager: API Improvements #114
Conversation
jleandroperez
changed the title
…nager-improvements
|
|
||
|
|
||
| /// Designated Initializer | ||
| /// |
There was a problem hiding this comment.
Delete repeated method documentation comments
There was a problem hiding this comment.
Thanks for catching that!!
| /// | ||
| private init() { } | ||
| var isAuthenticated: Bool { | ||
| return state is AuthenticatedState |
There was a problem hiding this comment.
hey I just reviewed this concept last week! is is the Swift way of checking type. It's much more elegant than saying[thisThing isKindOfClass: [MyThing class]]
There was a problem hiding this comment.
Exactly, it's the same thing!
| /// Shared Instance | ||
| /// | ||
| private static var state: StoresManagerState = initialState() { | ||
| static var shared = StoresManager(keychain: .shared) |
There was a problem hiding this comment.
I spy the first Singleton in our app
There was a problem hiding this comment.
Yeah... it was either this, or AppDelegate.shared.storesManager!!! =(
There was a problem hiding this comment.
I'm not against Singletons :)
There was a problem hiding this comment.
Ohhhh but i am!! 😄
| private var manager: StoresManager! | ||
|
|
||
|
|
||
| // MARK: - Overriden Methods |
There was a problem hiding this comment.
Overridden instead of Overriden
There was a problem hiding this comment.
Thanks for the heads up!!
|
@mindgraffiti ready for another peek! thanks in advance!! |
|
Thank you Thuy!! |
Details:
StoresManagerStoresManagerStateProtocol APICloses #93
Testing:
Please verify that the new (and shiny!) unit tests look green!