Skip to content

Conversation

@RafaelKayumov
Copy link
Contributor

@RafaelKayumov RafaelKayumov commented Oct 22, 2025

WOOMOB-1553

Description

Gates the "Card Reader" payment collection method for CIAB sites.

  • Moves CIABEligibilityChecker to Yosemite module to use it inside OrderCardPresentPaymentEligibilityStore
  • Creates and uses the CIABEligibilityChecker instance there to make an assessment for a card payment eligibility.
  • Removes StoresManager injection from CIABEligibilityChecker in favour of () -> Site? closure for simplicity and decoupling.

Testing steps

  • Use a CIAB site with unpaid orders
  • Navigate to an order that's not yet paid and eligible for a card payment.
  • Tap on "Collect Payment" CTA
  • Make sure the "Card Reader" option is not visible
  • Make sure the "Card Reader" option is displayed for eligible orders in non-CIAB sites.

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@RafaelKayumov RafaelKayumov added this to the 23.6 milestone Oct 22, 2025
@RafaelKayumov RafaelKayumov added the type: task An internally driven task. label Oct 22, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 22, 2025

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16270-49535da
Version23.5
Bundle IDcom.automattic.alpha.woocommerce
Commit49535da
Installation URL3i216c8v4r1ug
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@RafaelKayumov RafaelKayumov marked this pull request as ready for review October 23, 2025 13:16
@RafaelKayumov
Copy link
Contributor Author

I'll resolve conflicts after approval

@itsmeichigo itsmeichigo self-assigned this Oct 24, 2025
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and works as expected. Good job! 👍

# Conflicts:
#	Modules/Sources/Yosemite/Tools/CIAB/CIABEligibilityCheckerProtocol.swift
#	WooCommerce/Classes/ViewRelated/Dashboard/Settings/POS/POSTabVisibilityChecker.swift
@RafaelKayumov RafaelKayumov merged commit 8b6f4c3 into trunk Oct 24, 2025
13 checks passed
@RafaelKayumov RafaelKayumov deleted the WOOMOB-1553-hide-card-reader-for-CIAB-sites branch October 24, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: task An internally driven task.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants